Conversation
|
@Ocean-OS is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
I think |
There was a problem hiding this comment.
The new approach seems to error in cases where a title has a single quote character such as https://svelte.dev/docs/kit/images#Vite's-built-in-handling . It changes the single quote to a left single quote when it should be a right single quote as it is currently.
Possible edge cases we should account for:
a) Vite's built-in handling (right single quote)
b) "Vite's built-in handling" (smart double quotes with right single quote)
c) <script lang="ts"> (smart double quotes but in a single word)
I wonder if it's worth adding a unit test for this but I can see we don't have Vitest set up despite having a test command in the root package.json
Closes #781. I'm not entirely sure on what
firstdoes, or if I'm using it correctly in the logic, but everything else should be good.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.